Skip to content

Change 6.2.0rc1 to 6.2.0rc2 in version_switch.js #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021

Conversation

maxrjones
Copy link
Member

Description of proposed changes

Changes the 6.2.0rc1 switch to 6.2.0rc2 in version_switch.js.
Addresses #5191

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones requested a review from seisman May 20, 2021 18:08
@maxrjones
Copy link
Member Author

@seisman, do you think it is better to add a new switch or replace 6.2.0rc1 with 6.2.0rc2 as done in this PR?

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a reminder that, we may want to delete the 6.2.0rc1 directory in the gh-pages branch to reduce the branch size.

@maxrjones maxrjones merged commit 39882c1 into master May 20, 2021
@maxrjones maxrjones deleted the version-switch-rc2 branch May 20, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants