Skip to content

Remove xfails on solar and velo tests for GMT 6.2.0rc2 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2021
Merged

Remove xfails on solar and velo tests for GMT 6.2.0rc2 #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
512ac90
remove xfail from test_solar_default_terminator()
willschlitzer May 26, 2021
758252d
remove xfail from test_velo.py
willschlitzer May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pygmt/tests/test_solar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@ def test_invalid_datetime():
)


@pytest.mark.xfail(
reason="Flaky test only passes with pytest on single module"
"See https://github.com/GenericMappingTools/pygmt/issues/1242"
)
@pytest.mark.mpl_image_compare(filename="test_solar_set_terminator_datetime.png")
def test_solar_default_terminator():
"""
Expand Down
8 changes: 0 additions & 8 deletions pygmt/tests/test_velo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ def fixture_dataframe():
)


@pytest.mark.xfail(
reason="Flaky test only passes with pytest on single module"
"See https://github.com/GenericMappingTools/pygmt/issues/1242"
)
@pytest.mark.mpl_image_compare
def test_velo_numpy_array_numeric_only(dataframe):
"""
Expand Down Expand Up @@ -67,10 +63,6 @@ def test_velo_without_spec(dataframe):
fig.velo(data=dataframe)


@pytest.mark.xfail(
reason="Flaky test only passes with pytest on single module"
"See https://github.com/GenericMappingTools/pygmt/issues/1242"
)
@pytest.mark.mpl_image_compare
def test_velo_pandas_dataframe(dataframe):
"""
Expand Down