Skip to content

Feat: Custom Endpoint #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat: Custom Endpoint #21

wants to merge 2 commits into from

Conversation

Lakr233
Copy link
Contributor

@Lakr233 Lakr233 commented Sep 19, 2023

No description provided.

unixzii
unixzii approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@unixzii unixzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

unixzii
unixzii requested changes Sep 19, 2023
View reviewed changes
src/config.rs

/// The API Endpoint to be used.
/// JSON key: `openaiAPIEndpoint`
#[serde(rename = "openaiAPIEndpoint")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add a default value here, since most people probably won't change the endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixzii unixzii unixzii requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lakr233 @unixzii