CSharp example #18
Open
CSharp example #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxMelnik
changed the title
1. Changed access modifier of Node fields 2. Updated return functions
Raixur
reviewed
Jun 6, 2017
There was a problem hiding this comment.
- You may add a reference on head/first element to keep order in which element was added.
- Lists should implement at least IEnumerable interface.
- You may add some functionality to your classes, e.g. Contains, Remove, Count methods. Also, you may overload index operator.
| { | ||
| internal T item; | ||
| internal Node next; | ||
| internal Node previous; |
There was a problem hiding this comment.
Modifier can be public because class Node is inner private, so fields can be accessed only in DoubleLinkedList class scope.
| { | ||
| List<T> res = new List<T>(); | ||
| Node temp = last; | ||
| T item = default(T); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.