[Resource] Remove computed property from pi_instance "pi_placement_group_id", fix placement group acceptance test, add wait for placement group delete #6230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yussufsh
reviewed
May 10, 2025
…up_id and fix placement group acceptance test
Alexander-Kita
force-pushed
the
fix-pg-remove-behavior
branch
from
ecc956a to
5d59d8d
Compare
Alexander-Kita
changed the title
yussufsh
reviewed
May 15, 2025
|
|
||
| _, err = isWaitForPIPlacementGroupDeleted(ctx, client, parts[1], d.Timeout(schema.TimeoutDelete)) |
There was a problem hiding this comment.
Please revisit timeouts in future PRs... 60 mins is too much here.
yussufsh
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Description:
Computed: truewas erroneously added topi_placement_group_idargument inpi_instanceresource refactor. This resulted in the placement group acceptance tests failing and a slight behavior change. This PR removes that property and fixes errors in placement group acceptance tests.Instance refactor PR: #5385
Output from acceptance testing: