Skip to content

Handle tuples in build_function.jl #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

5hv5hvnk
Copy link

@5hv5hvnk 5hv5hvnk commented Mar 3, 2025

Solves #1438
Added a work around to treat tuples as array and then return a tuple by converting it to a list.

ToDo:

  • Add tests

@ChrisRackauckas
Copy link
Member

This would allocate though?

@5hv5hvnk
Copy link
Author

5hv5hvnk commented Mar 3, 2025

I think so, I can probably write some tests to verify?
I tried it on the example in issue and it was working, not sure if it will generalize.

@ChrisRackauckas
Copy link
Member

Yes write some tests that check if the tuple route is non-allocating on simple functions. I don't think it would pass.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 7.70%. Comparing base (eced900) to head (b1f2e5d).
Report is 164 commits behind head on master.

Files with missing lines Patch % Lines
src/build_function.jl 0.00% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1462      +/-   ##
=========================================
- Coverage    8.88%   7.70%   -1.18%     
=========================================
  Files          51      51              
  Lines        4876    4943      +67     
=========================================
- Hits          433     381      -52     
- Misses       4443    4562     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisRackauckas
Copy link
Member

@AayushSabharwal how do this come into your changes to function building?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants