Skip to content

Fix failed BGP Route checks being counted twice #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix failed BGP Route checks being counted twice #29

wants to merge 1 commit into from

Conversation

EmanuelMairoll
Copy link
Contributor

No description provided.

@lorenzo93
Copy link
Member

lorenzo93 commented May 5, 2025 •
edited
Loading

Hi @EmanuelMairoll,

Thank you for the PR.
The continue is avoided on purpose. In fact, if left without, it is possible from the results to know which were the inconsistent routes. The same behaviour is also in the BGP neighbor check.
The idea is that with the results of the checker you can grade the students without needing other information ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmanuelMairoll @lorenzo93