fix dropdown bug #541
fix dropdown bug #541
Conversation
🦋 Changeset detectedLatest commit: 5fb89c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| </div> | ||
|
|
||
| {/* Dropdown items - Use windowing for large lists */} | ||
| <div className="max-h-[300px] overflow-y-auto"> |
There was a problem hiding this comment.
Just a gut feeling, didn't try it but would removing only the overflow-y-auto class here solve not the issue as well, without the need for all the other changes being done?
There was a problem hiding this comment.
it doesn't work, unless you want the search bar to also scroll within the container? I'll try and clean it up, it wasn't a lot of changes but the diff makes it look like it is, I just had to remove a wrapped div
There was a problem hiding this comment.
Ah ok, clear! The div looked huge but makes sense then indeed! Can you drop a comment somewhere near it with a kilocode_change marker that says that it was removed intentionally?
There was a problem hiding this comment.
When looking at it with whitespace ignored the diff doesn't look so big anymore :) In fact most of the changes below come from the reduced indentation causing Prettier to put things on the same line.
There was a problem hiding this comment.
prettier loves 🧌 -ing diffs, alas.
| ) : ( | ||
| <div className="py-1"> | ||
| {groupedOptions.map((option, index) => { | ||
| // Memoize rendering of each item type for better performance |
There was a problem hiding this comment.
Unnecessarily removed comment
| ) | ||
| } | ||
|
|
||
| // Use stable keys for better reconciliation |
There was a problem hiding this comment.
Unnecessarily removed comment
Context
Fixes #465
-->
Screenshots
Before
After
