Skip to content

Update Makefile #7354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Makefile #7354

wants to merge 1 commit into from

Conversation

oldthreefeng
Copy link
Contributor

@oldthreefeng oldthreefeng commented Apr 17, 2025

when metadata changes to pkg. makefile should change too.

What this PR does / why we need it:

Which issue this PR fixes:
docker run --rm kong/kubernetes-ingress-controller:3.4.4 version
{"release":"NOT_SET","repo":"NOT_SET","commit":"NOT_SET"}

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

when metadata changes to pkg.  makefile should change too.
@oldthreefeng oldthreefeng requested a review from a team as a code owner April 17, 2025 03:28
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.1%. Comparing base (7ca01f3) to head (c2f0f68).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #7354     +/-   ##
=======================================
- Coverage   77.2%   77.1%   -0.1%     
=======================================
  Files        220     220             
  Lines      25309   25309             
=======================================
- Hits       19542   19536      -6     
- Misses      4773    4777      +4     
- Partials     994     996      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@randmonkey
Copy link
Contributor

@oldthreefeng Thanks for contributing. We are sorry that due to some security reasons, the tests cannot run on branches from fork, so we cherry-picked your commit to #7359. Your contribution will still be recorded.

@randmonkey randmonkey closed this Apr 22, 2025
@randmonkey
Copy link
Contributor

Closed this as #7359 is merged. Thanks for contributing and sorry for not being able to merge your PR directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants