Skip to content

Update MenuItem to use AppLink #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update MenuItem to use AppLink #1807

wants to merge 7 commits into from
+62 −69

Conversation

labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Jun 6, 2025 •
edited
Loading

Rationale

This addresses Issue 52458 where clicking on menu items would navigate away from a "dirty" page without warning.

Related Pull Requests

Changes

  • Update AppLink to extend all props of AnchorHTMLAttributes
  • Update MenuItem to use AppLink
  • Update all usages of MenuItem to pass AppURL where possible

@labkey-nicka labkey-nicka requested a review from labkey-alan June 6, 2025 21:52
@labkey-nicka labkey-nicka self-assigned this Jun 6, 2025
@labkey-nicka labkey-nicka mentioned this pull request Jun 9, 2025
Open
labkey-alan
labkey-alan approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@labkey-alan labkey-alan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for tackling this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-alan labkey-alan labkey-alan approved these changes

Assignees

@labkey-nicka labkey-nicka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-nicka @labkey-alan