feat: adding new activity configuration #4794
Open
+845
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelsonbrito
force-pushed
the
feat/notify-on-document-signed
branch
from
581f582 to
562a62d
Compare
vitormattos
requested changes
Apr 8, 2025
samuelsonbrito
changed the title
|
I'm making progress toward completing the activity trigger. I’ve added a direct trigger with mocked data just to verify that the trigger works correctly. Now, I’ll remove the mocked data and replace it with real data using the signature object. |
|
Trigger activity:
|
samuelsonbrito
force-pushed
the
feat/notify-on-document-signed
branch
3 times, most recently
from
98849c1 to
064a068
Compare
vitormattos
requested changes
May 10, 2025
|
Trigger notification:
|
vitormattos
reviewed
May 13, 2025
|
Send an email:
|
vitormattos
reviewed
May 14, 2025
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
samuelsonbrito
force-pushed
the
feat/notify-on-document-signed
branch
from
ca7347e to
dc72ad4
Compare
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
Signed-off-by: Samuelson Brito <samuelsonma@gmail.com>
The right way to match if have any occurrency of a jq sentence that return true, is using the function any. The previous sentence was matching all items and was returning many boolean values as output of jq command. The any function return only the first true value. Signed-off-by: Vitor Mattos <vitor@php.rio>
The most generic type that this class implement is Event and the before type is most specific. Here we need a most generic type. Signed-off-by: Vitor Mattos <vitor@php.rio>
This will make more easy to add new activities. Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
approved these changes
May 16, 2025
The action trigged by notify_unsigned_user now is the same as activity, notify_email_libresign_file_to_sign. Signed-off-by: Vitor Mattos <vitor@php.rio>
This scenario only validate the signature with password Signed-off-by: Vitor Mattos <vitor@php.rio>
This scenario don't validate email routines Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
If admin disable this setting, the user can enable and to don't have a wrong result at this scenario, is necessary to toggle the user settings to be compliance with scenario purpose. Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activity Settings Page:
Related Issue
Issue Number: #2618
Pull Request Type
Pull request checklist