Feat/login #324
Open
Feat/login #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LossyDragon
requested changes
Mar 14, 2025
| LogManager.addListener(new DefaultLogListener()); | ||
|
|
||
| new SampleWebLogonNonce(args[0], args[1]).run(); | ||
| Thread.sleep(1000000L); |
There was a problem hiding this comment.
I don't think this is needed here. Once the client is finished, it should terminate instead of waiting a long time.
| client.setProxy(proxy); | ||
| client.run(); | ||
|
|
||
| Thread.sleep(1000000L); |
There was a problem hiding this comment.
I don't think this is needed here. Once the client is finished, it should terminate instead of waiting a long time.
|
|
||
|
|
||
| /** | ||
| * @author cap_qin |
There was a problem hiding this comment.
This an alias? Also date would be nice here.
| Socket underlying = new Socket(new Proxy(Proxy.Type.SOCKS, proxy.address())); | ||
| underlying.connect(endPoint,timeout); | ||
| socket = underlying; | ||
| // socket = factory.createSocket( |
There was a problem hiding this comment.
Can remove block if no longer needed.
| client = HttpClient(CIO) { | ||
| install(WebSockets) { | ||
| pingInterval = timeout.toDuration(DurationUnit.SECONDS) | ||
| } | ||
|
|
There was a problem hiding this comment.
English comment is preferred to keep consistency.
| logon.body.setAccountName(details.username); | ||
| logon.body.setWebLogonNonce(details.webLogonNonce); | ||
| logon.body.setClientOsType(EOSType.Web.code()); | ||
| logon.body.setUiMode(4); |
There was a problem hiding this comment.
Would EUIMode work here?
There was a problem hiding this comment.
I will remove it, It's not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support login with webLogonNonce and connection with proxy
webLogonNonce login is more safe, it's once time token which can login account to connect steam server, you can get the webLogonNonce from
https://steamcommunity.com/chat/clientjstokenproxy support is necessary I think, GC server recently give the more strict limit for ip, proxy is the better way to make connection with GC server
Checklist