Skip to content

Added days_since_last_logon attribute to Windows ntuser test #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vanderpol
Copy link
Member

Added element per discussions with @solind

@vanderpol vanderpol added the Microsoft Issue related to the Microsoft schema. label Apr 10, 2025
@vanderpol vanderpol added this to the 5.12.1 milestone Apr 10, 2025
@vanderpol vanderpol requested a review from solind April 10, 2025 14:15
@vanderpol vanderpol self-assigned this Apr 10, 2025
Copy link

@solind solind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "rounded" too ambiguous? I think if it's been < 24 hrs since the last login, perhaps this should be 0, less than 48 hrs than 1, etc. Kind of like the proverbial "days since last accident" sign on a jobsite.

@vanderpol
Copy link
Member Author

Is "rounded" too ambiguous? I think if it's been < 24 hrs since the last login, perhaps this should be 0, less than 48 hrs than 1, etc. Kind of like the proverbial "days since last accident" sign on a jobsite.

Sounds reasonable, how about

The last_logon data, converted to days and then rounded down to the nearest integer (floor function). If the account is determined to be currently logged in, this date should be reported as 0.

@solind
Copy link

solind commented Apr 15, 2025

Works for me.

@vanderpol vanderpol requested a review from solind May 10, 2025 19:33
@vanderpol vanderpol merged commit 5930916 into 5.12.1_develop May 19, 2025
@vanderpol vanderpol changed the title Added days_since_last_logon attribute to resolve #221 Added days_since_last_logon attribute to Windows ntuser test May 20, 2025
@vanderpol vanderpol deleted the 221-add-days_since_last_logon-to-the-windows-ntuser-item-and-state branch May 20, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Microsoft Issue related to the Microsoft schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants