-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Port MASTG-TEST-0036: Testing Enforced Updating (android) #3234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port MASTG-TEST-0036: Testing Enforced Updating (android) #3234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't comply with our guidelines. Please check them out before proceeding. See our previous discussions here:
Turning into "DRAFT" until the files are compliant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't belong to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't belong to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't comply with the required structure and style as defined in our guidelines. Please check them out before proceeding.
@cpholguera I have removed unrelated files and fixed Markdown linting. Please review again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aakarshgopishetty kindly follow the structure and update changes accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the links to the guidelines as well as the specific guidelines for writing new tests and demos here:
https://docs.google.com/document/d/1EMsVdfrDBAu0gmjWAUEs60q-fWaOmDB5oecY9d9pOlg/edit?tab=t.0
-
The file is located in the wrong directory.This new porting
MASTG-TEST-xxxx.md
file needs to be located intests-beta/android/MASVS-CODE/
and should include the following essential elements.- Metadata
--- platform: android title: Enforced Updating id: MASTG-TEST-0x36 type: [static] weakness: MASWE-0075 ---
- Body
## Overview ## Steps ## Observation ## Evaluation
Here’s a example of the MASTG-TEST-0254 structure https://github.com/OWASP/owasp-mastg/blob/f041b2c60afc81452095bd921e243309c817e292/tests-beta/android/MASVS-PRIVACY/MASTG-TEST-0254.md
- Metadata
Demo
-
A demo needs to be developed for
MASTG-TEST-xxxx
using the demo application found at https://github.com/cpholguera/MASTestApp-Android.
For this demo should be located in the directorydemos/android/MASVS-CODE/MASTG-DEMO-xxxx/
. -
The Semgrep rule for the application needs to be located beneath
rules/mastg-android-xxxx.yaml
. i.e https://github.com/OWASP/owasp-mastg/tree/f041b2c60afc81452095bd921e243309c817e292/rules
Here’s an example of the demo folder structure:
https://github.com/OWASP/owasp-mastg/tree/f041b2c60afc81452095bd921e243309c817e292/demos/android/MASVS-PRIVACY/MASTG-DEMO-0033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
This file doesn't belong to this PR , the MASTG-TEST-0036 is associated with this testcase
-
When dealing with "porting tests" issues, you won't be modifying the V1 tests. Instead, you'll mark them as deprecated and indicate the new tests to be used at the end of the metadata.
status: deprecated covered_by: [MASTG-TEST-0x36] deprecation_note: New version available in MASTG V2
@aakarshgopishetty any news on this? Thanks |
@aakarshgopishetty any update on this ? Please let us know if you have any doubts. thank you |
Hi @sk3l10x1ng , I'm a bit confused about how to create the demo and add the Semgrep rule for the MASTG-TEST-0036 port. Could you please help clarify how I should proceed with these tasks? |
@aakarshgopishetty
|
@aakarshgopishetty you can refer to the https://mas.owasp.org/MASTG/tests/android/MASVS-CODE/MASTG-TEST-0036/ for creating a demo for the testcase |
@aakarshgopishetty any update ? |
1 similar comment
@aakarshgopishetty any update ? |
Hi @sk3l10x1ng and @cpholguera, Thank you for your continued support and detailed guidance throughout the process. After reviewing the requirements and steps involved, I've realized that I'm currently not equipped with the necessary experience and skills to implement the demo and create the corresponding Semgrep rule as required for this test case. At this time, I won’t be able to complete the remaining work on this PR. I truly appreciate the opportunity to contribute and learn from this experience. I hope to come back and contribute again in the future once I’ve built up more expertise. Thank you again for your time and understanding. Best regards, |
Thank you, @aakarshgopishetty. We really appreciate your willingness to learn and contribute. Wishing you all the best on your learning journey! We’ll go ahead and close the PRs for now. Take care, and thanks again! |
Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:
If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2994.