PSR2/PropertyDeclaration: update for properties with asymmetric visibility #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility [1] Per the FIG PSR-PER updates (next version), the "properties must have visibility declared" rule is also satisfied if only write visibility is declared. > The `public` keyword MAY be omitted when using a set-visibility on a public-read property. Includes updated test expectations (on the tests previously added in 871). Refs: * php-fig/per-coding-style 99 * php-fig/per-coding-style 114
…ility [2] Per the FIG PSR-PER updates (next version), the "set-visibility MUST be _after_ the (read-)visibility". This commit implements this, but as there may be two visibility modifiers, a minor refactor of the code involved in the wrong order checks for the `final` keyword and the `static` and `readonly` keywords is also needed as we can no longer presume that we can use the visibility keyword found with a search backwards to re-position other keywords. Includes plenty of tests. Includes a minor update to pre-existing test expectations (whitespace only), which is related to the refactor of the "fix"-code. As this sniff does not enforce any spacing requirements after the keywords, this difference is neglicable for the purpose of this sniff. Note: in a future iteration, we may want to look at making the code for the "order" checks more efficient, but for now, at least it will work correctly again. Refs: * php-fig/per-coding-style 99 * php-fig/per-coding-style 114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PSR2/PropertyDeclaration: update for properties with asymmetric visibility [1]
Per the FIG PSR-PER updates (next version), the "properties must have visibility declared" rule is also satisfied if only write visibility is declared.
Includes updated test expectations (on the tests previously added in #871).
PSR2/PropertyDeclaration: update for properties with asymmetric visibility [2]
Per the FIG PSR-PER updates (next version), the "set-visibility MUST be after the (read-)visibility".
This commit implements this, but as there may be two visibility modifiers, a minor refactor of the code involved in the wrong order checks for the
finalkeyword and thestaticandreadonlykeywords is also needed as we can no longer presume that we can use the visibility keyword found with a search backwards to re-position other keywords.Includes plenty of tests.
Includes a minor update to pre-existing test expectations (whitespace only), which is related to the refactor of the "fix"-code. As this sniff does not enforce any spacing requirements after the keywords, this difference is neglicable for the purpose of this sniff.
Note: in a future iteration, we may want to look at making the code for the "order" checks more efficient, but for now, at least it will work correctly again.
Suggested changelog entry
Related issues/external references
Refs:
Follow up on #851
Follow up on #1116
Related to #734