Various sniffs: add tests for properties with asymmetric visibility #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tric visibility This sniff already handles this correctly. This commit just updates the tests to safeguard this for the future.
…lity This sniff already handles this correctly. This commit just updates a test to safeguard this for the future.
…isibility Sniff already behaves as intended as the parent sniff `LowerCaseConstant` inherits support via the `Tokens::$scopeModifiers` array since PR 871. This commit just adds some extra tests to safeguard this for the future.
…ility This sniff already handles this correctly. This commit just updates a test to safeguard this for the future.
…ibility Sniff already behaves as intended. This commit just adds some extra tests to safeguard this for the future.
…bility Sniff already behaves as intended. This commit just adds some extra tests to safeguard this for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic/UnusedFunctionParameter: add tests for properties with asymmetric visibility
This sniff already handles this correctly.
This commit just updates the tests to safeguard this for the future.
Generic/LowerCaseType: add test for properties with asymmetric visibility
This sniff already handles this correctly.
This commit just updates a test to safeguard this for the future.
Generic/UpperCaseConstant: add tests for properties with asymmetric visibility
Sniff already behaves as intended as the parent sniff
LowerCaseConstantinherits support via theTokens::$scopeModifiersarray since PR #871.This commit just adds some extra tests to safeguard this for the future.
PEAR/ValidDefaultValue: add test for properties with asymmetric visibility
This sniff already handles this correctly.
This commit just updates a test to safeguard this for the future.
Squiz/ValidVariableName: add tests for properties with asymmetric visibility
Sniff already behaves as intended. This commit just adds some extra tests to safeguard this for the future.
Zend/ValidVariableName: add tests for properties with asymmetric visibility
Sniff already behaves as intended. This commit just adds some extra tests to safeguard this for the future.
Suggested changelog entry
N/A
Related issues/external references
Follow up on #851
Follow up on #1116
Related to #734