Skip to content

feat: Implement with_response For Interaction Callbacks #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Icebluewolf
Copy link
Contributor

@Icebluewolf Icebluewolf commented Feb 11, 2025

Summary

Implements with_response for interaction callbacks.

This will update Interaction.message to avoid needing to call Interaction.original_response()
It also adds the is_loading() and is_ephemeral()

It was decided to always enable with_response instead of allowing the user to specify if they want it per #discussion on Discord.

The #type: ignore comment is because I copy pasted that code from somewhere else. They did not specify why they were ignoring.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Icebluewolf Icebluewolf marked this pull request as ready for review February 15, 2025 06:08
@Icebluewolf Icebluewolf requested a review from a team as a code owner February 15, 2025 06:08
@pullapprove4 pullapprove4 bot requested a review from VincentRPS February 15, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant