feat: Add support for Guild Scheduled Event Recurrence #2749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plun1331
reviewed
Mar 31, 2025
discord/scheduled_events.py
Outdated
Comment on lines
256
to
290
| @property | ||
| def weekdays(self) -> list[WeekDay]: | ||
| """Returns a read-only list containing all the specific days | ||
| within a week on which the event will recur on. | ||
| """ | ||
| if self._weekdays is MISSING: | ||
| return [] | ||
| return self._weekdays.copy() | ||
|
|
||
| @property | ||
| def n_weekdays(self) -> list[NWeekDay]: | ||
| """Returns a read-only list containing all the specific days | ||
| within a specific week on which the event will recur on. | ||
| """ | ||
| if self._n_weekdays is MISSING: | ||
| return [] | ||
| return self._n_weekdays.copy() | ||
|
|
||
| @property | ||
| def month_days(self) -> list[datetime.date]: | ||
| """Returns a read-only list containing all the specific days | ||
| within a specific month on which the event will recur on. | ||
| """ | ||
| if self._month_days is MISSING: | ||
| return [] | ||
| return self._month_days.copy() | ||
|
|
||
| @property | ||
| def year_days(self) -> list[int]: | ||
| """Returns a read-only list containing all the specific days | ||
| of the year on which the event will recur on. | ||
| """ | ||
| if self._year_days is MISSING: | ||
| return [] | ||
| return self._year_days.copy() |
There was a problem hiding this comment.
Any reason these are read-only properties?
There was a problem hiding this comment.
Because as recurrence rules can be both received by API/Gw and created by users, I thought it would be better to make these properties read only and if the user wants to edit the rrule they use edit instead. (Similar as dateutil.rrule.rrule.replace)
There was a problem hiding this comment.
Read only makes more sense to me
There was a problem hiding this comment.
That seems inconsistent to me, no other object in the library does this
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Icebluewolf
reviewed
Apr 4, 2025
discord/scheduled_events.py
Outdated
| ), | ||
| ], | ||
| ) | ||
| Creating a recurrence rule that repeats anually on July 24: :: |
There was a problem hiding this comment.
Ah okay, lol, i'll update it
… into feat/recurrence-rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for receiving, setting, and updating a Scheduled Event's recurrence rule.
Documentation: resources/guild-scheduled-event
Needs testing.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.