fix: fix a resource a type error when using async _resolved function #7426
Conversation
🦋 Changeset detectedLatest commit: 872fe37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
@maiieul please help me to review |
packages/qwik/src/core/api.md
Outdated
| @@ -886,7 +886,7 @@ export interface ResourceProps<T> { | |||
| // (undocumented) | |||
| onRejected?: (reason: Error) => JSXOutput; | |||
| // (undocumented) | |||
| onResolved: (value: T) => JSXOutput; | |||
| onResolved: (value: T) => JSXOutput | Promise<JSXOutput>; | |||
There was a problem hiding this comment.
I believe we should also change the type for onPending and onRejected
| const resource = props.value as ResourceReturnInternal<T> | Promise<T> | Signal<T>; | ||
| let promise: Promise<T> | undefined; | ||
| if (isResourceReturn(resource)) { | ||
| if (isResourceReturn(resource) && resource.value) { |
There was a problem hiding this comment.
Do we need to add the && resource.value?
There was a problem hiding this comment.
Do we need to add the
&& resource.value?
Maybe resource is signal @maiieul
There was a problem hiding this comment.
the resource is always a promise, no?
This commit refactors the preloader and bundle graph handling to improve performance and maintainability. Key changes include: - Removed `qwikloader-prefetch.ts` and `qwikloader-entry.ts` as they are no longer needed. - Updated the preloader configuration to use more descriptive variable names and optimized preload probabilities. - Changed the bundle graph output from `.js` to `.json` for better clarity and compression. - Added a new test for the preloader script to ensure its integrity and size. - Updated API Extractor configurations across multiple packages to use consistent naming and newline settings. These changes aim to enhance the efficiency of Qwik's preloading mechanism and ensure better maintainability of the codebase.
| onResolved: (value: T) => JSXOutput | Promise<JSXOutput>; | ||
| onPending?: () => JSXOutput | Promise<JSXOutput>; |
There was a problem hiding this comment.
I don't understand why this is needed. The resource holds a Promise, but the Resource component should just render without a Promise
| const resource = props.value as ResourceReturnInternal<T> | Promise<T> | Signal<T>; | ||
| let promise: Promise<T> | undefined; | ||
| if (isResourceReturn(resource)) { | ||
| if (isResourceReturn(resource) && resource.value) { |
There was a problem hiding this comment.
the resource is always a promise, no?
What is it?
fixes: #7086
follow version 2 to fix this ts error
Description
Checklist
pnpm change