Skip to content

Update all deps minor #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

sreeisalso
Copy link
Contributor

What is it?

  • Feature / enhancement

Description

updated all deps minor to latest

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: cd8ea42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sreeisalso
Copy link
Contributor Author

I'm trying this just to make sure there are no breaking changes similar to #7528

@sreeisalso
Copy link
Contributor Author

@wmertens I'm stuck, can you guide me where to look.

@wmertens
Copy link
Member

@sreeisalso looks like a require() call snuck into esm code. Try to figure out where it happens (open the files in the stack trace) and maybe you'll have to downgrade some deps. See https://dev.to/marcogrcr/nodejs-and-esbuild-beware-of-mixing-cjs-and-esm-493n for some similarities.

Copy link

pkg-pr-new bot commented Apr 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7529
npm i https://pkg.pr.new/@builder.io/qwik-city@7529
npm i https://pkg.pr.new/eslint-plugin-qwik@7529
npm i https://pkg.pr.new/create-qwik@7529

commit: cd8ea42

@sreeisalso
Copy link
Contributor Author

@sreeisalso looks like a require() call snuck into esm code. Try to figure out where it happens (open the files in the stack trace) and maybe you'll have to downgrade some deps. See https://dev.to/marcogrcr/nodejs-and-esbuild-beware-of-mixing-cjs-and-esm-493n for some similarities.

yes, yaml 2.7.0 and above causing this issue, thanks for the help

@sreeisalso sreeisalso marked this pull request as ready for review April 24, 2025 10:57
@sreeisalso sreeisalso requested review from a team as code owners April 24, 2025 10:57
Copy link
Contributor

github-actions bot commented Apr 24, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview cd8ea42

@wmertens
Copy link
Member

@sreeisalso it has merge conflicts now. Can you fix? I'll merge this after we release 1.14

@sreeisalso
Copy link
Contributor Author

@sreeisalso it has merge conflicts now. Can you fix? I'll merge this after we release 1.14

@wmertens resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants