Add best practice for warpSize handling #3790
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randyh62
approved these changes
May 14, 2025
There was a problem hiding this comment.
The discussion on warpSize at line 415 refers to "hardware features" but it seems like some mention of the fact that warpSize and Wavefront size are the same would be useful here?
|
LGTM |
ritter-x2a
reviewed
May 26, 2025
| - Retrieves the warp size of the GPU (warpSizeHost) to determine the optimal | ||
| kernel configuration. | ||
|
|
||
| - Allocates device memory (`d_data`` for input, `d_results`` for block-wise |
There was a problem hiding this comment.
The backticks around d_data and d_results are not properly matched.
ritter-x2a
reviewed
May 26, 2025
| accordingly, as shown in the following block reduce example. | ||
|
|
||
| The ``block_reduce`` kernel has a template parameter for warpSize and reduction | ||
| operation in two main phases: |
There was a problem hiding this comment.
The second part of the sentence seems to lack a verb for me, maybe something like "...and performs a reduction operation in two main phases:"?
ritter-x2a
reviewed
May 26, 2025
ritter-x2a
reviewed
May 26, 2025
Co-authored-by: Fabian Ritter <ritter.x2a@gmail.com>
ritter-x2a
reviewed
May 26, 2025
Co-authored-by: Fabian Ritter <ritter.x2a@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.