Skip to content

Only decorate physically sized types with ArrayStride #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Only decorate physically sized types with ArrayStride #239

merged 2 commits into from
Apr 21, 2025

Conversation

jwollen
Copy link
Contributor

@jwollen jwollen commented Apr 21, 2025

Stop decorating RuntimeArrays of unsized types with ArrayStride. Fixes the spirv-val rule:

Array containing a Block or BufferBlock must not be decorated with ArrayStride

This already works correctly when using qptrs.

Firestar99
Firestar99 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@Firestar99 Firestar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
just fixed the lint errors so we can merge this

@Firestar99 Firestar99 enabled auto-merge April 21, 2025 14:17
@Firestar99 Firestar99 added this pull request to the merge queue Apr 21, 2025
Merged via the queue into Rust-GPU:main with commit f6e22b4 Apr 21, 2025
7 checks passed
@LegNeato
Copy link
Collaborator

Thank you so much for the PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firestar99 Firestar99 Firestar99 approved these changes

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@LegNeato LegNeato Awaiting requested review from LegNeato LegNeato is a code owner

@schell schell Awaiting requested review from schell schell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwollen @LegNeato @Firestar99