You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The click event listener on line 130 might not work as expected for all modal elements. It only checks if the clicked element's ID starts with 'codeModal_', but this would only close the modal if the background overlay itself is clicked, not its children.
document.addEventListener('click', function(e) {
if (e.target.id && e.target.id.startsWith('codeModal_')) {
const id = e.target.id.replace('codeModal_', '');
closeCodeModal(id);
}
});
The copyCode function references 'event' on line 98 but doesn't declare it as a parameter, which could cause issues in strict mode or when called programmatically without an event context.
✅ Fix event handlingSuggestion Impact:The commit implemented the suggestion by modifying both the function definition to accept the event parameter and updating the onclick handler to pass the event
The copyCode function uses the global event object which is deprecated and may not be available in all browsers. Pass the event as a parameter to ensure reliable access to the clicked button.
Why: Valid improvement addressing the deprecated global event object by accepting an event parameter, enhancing browser compatibility and code reliability.
Medium
✅ Pass event to functionSuggestion Impact:The commit directly implemented the suggestion by updating both the onclick handler to pass the event parameter and the copyCode function definition to accept this parameter.
Why: Necessary complementary change to suggestion 2, properly passing the event object to the copyCode function for reliable event handling.
Medium
Possible issue
Fix modal click behavior
The click event listener will only close the modal when clicking directly on the modal element, not its children. Modify the event listener to check if the clicked element is the modal background (the outer div) to ensure users can click anywhere outside the content area to dismiss the modal.
document.addEventListener('click', function(e) {
if (e.target.id && e.target.id.startsWith('codeModal_')) {
- const id = e.target.id.replace('codeModal_', '');- closeCodeModal(id);+ // Only close if clicking the background (not the modal content)+ if (e.target === document.getElementById(e.target.id)) {+ const id = e.target.id.replace('codeModal_', '');+ closeCodeModal(id);+ }
}
});
Apply / Chat
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly identifies a UX issue where clicking anywhere on a modal element closes it, rather than only closing when clicking the background. This could lead to unexpected modal closures when users interact with modal content.
Low
Prevent unwanted modal closing
The modal content doesn't prevent event propagation, which means clicks inside the modal will bubble up to the background and close the modal. Add a click handler to the modal content div to stop event propagation.
Why: This suggestion complements the first one by preventing event propagation from modal content to the background. It addresses the same modal interaction issue and provides a valid solution to prevent unintended modal closures.
Low
General
Add clipboard error handling
The document.execCommand('copy') method is deprecated. While you have a fallback mechanism, it's better to provide user feedback if copying fails. Add error handling to inform users when the clipboard operation fails.
-document.execCommand('copy');+try {+ document.execCommand('copy');+} catch (err) {+ alert('Copy failed. Please try again or copy the code manually.');+ console.error('Copy failed:', err);+ return;+}
Apply / Chat
Suggestion importance[1-10]: 4
__
Why: While document.execCommand('copy') is deprecated, this suggestion adds error handling for the fallback scenario when navigator.clipboard is unavailable. This is a minor improvement that enhances robustness but doesn't address a critical issue.
* feat: add button to show full code example
* fix: apply bot code suggestions
* set border style for buttons
---------
[deploy site]
Co-authored-by: Diego Molina <diemol@users.noreply.github.com> 2fc8f70
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
add show example, inspired from PR #2276
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add "Show full example" button for code snippets with line fragments
Improve user experience for viewing and copying full code examples
Changes walkthrough 📝
gh-codeblock.html
Add modal to display and copy full code examplewebsite_and_docs/layouts/shortcodes/gh-codeblock.html
shortcuts