Skip to content

fix(TransitionablePortal): fix onClose call #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/addons/TransitionablePortal/TransitionablePortal.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,17 @@ export default class TransitionablePortal extends Component {
handleTransitionHide = (nothing, data) => {
debug('handleTransitionHide()')
const { portalOpen } = this.state
const { open } = this.props

this.setState({ transitionVisible: false })
_.invoke(this.props, 'onClose', null, { ...data, portalOpen: false, transitionVisible: false })

if (_.isUndefined(open) || open) {
_.invoke(this.props, 'onClose', null, {
...data,
portalOpen: false,
transitionVisible: false,
})
}
_.invoke(this.props, 'onHide', null, { ...data, portalOpen, transitionVisible: false })
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,17 @@ describe('TransitionablePortal', () => {
}, done)
})

it('is not called if portal already closed ', () => {
const onClose = sandbox.spy()

wrapperMount(
<TransitionablePortal {...requiredProps} onClose={onClose} transition={quickTransition} />,
)

wrapper.setProps({ open: false })
onClose.should.not.have.been.called()
})

it('changes `portalOpen` to false', () => {
wrapperMount(
<TransitionablePortal
Expand Down