Prevent crash when loading bad blockdata #7795
Open
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
requested review from
Efnilite and
Pesekjak
and removed request for
a team
Efnilite
approved these changes
Apr 12, 2025
APickledWalrus
approved these changes
Apr 30, 2025
|
@sovdeeth rebase for patch? edit: old enough for me to do it easily |
APickledWalrus
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents crash when loading blockdata that's no longer valid (see changes to creaking heart blockdata between 1.21.3 and 1.21.4).
Previously, Skript would hard crash if it encountered this. Now, it fails to load just that variable and everything else is normal.
Previous:
New:
Target Minecraft Versions: any
Requirements: none
Related Issues: none