Skip to content

EffSecShoot Fix Sections/Consumers #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev/patch
Choose a base branch
from

Conversation

Absolutionism
Copy link
Contributor

Description

This PR aims to fix EffSecShoot:

  • When using a section, the shot/spawned entity data did not have the velocity set. Due to the consumers not setting the velocity.
  • 1.20.1- World#spawn with Consumer used Bukkit consumers

Adds tests for each CaseUsage via spawning a fireball, projectile, and an entity, from both a living entity shooter and a location shooter, matching the velocities.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7824

@Absolutionism Absolutionism requested a review from a team as a code owner April 24, 2025 23:37
@Absolutionism Absolutionism requested review from APickledWalrus and cheeezburga and removed request for a team April 24, 2025 23:37
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 24, 2025
@Absolutionism Absolutionism requested a review from sovdeeth April 25, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants