Add Option to Print Errors in Reload Script Effect #7830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Errors
requested review from
Romitou and
Pesekjak
and removed request for
a team
sovdeeth
requested changes
Apr 25, 2025
src/main/java/ch/njol/skript/expressions/ExprScriptFileErrors.java
Outdated
Show resolved
Hide resolved
sovdeeth
added
the
enhancement
Mr-Errors
changed the title
sovdeeth
changed the title
|
Note that this PR only displays errors rather than the traditional 3 step process of: The prologue and epilogue statements would need to be pulled from SkriptCommand and should probably be pulled out into a separate class, but while discussing with @Mr-Errors I thought it best to leave that for a separate PR that can be make a more cohesive API for both EffScriptFile and SkriptCommand |
sovdeeth
approved these changes
Apr 29, 2025
Efnilite
approved these changes
Apr 29, 2025
Efnilite
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add options with errors in the reload script effect, This leads to fix the problem with the reload script effect it didn't seem to have a option to have some type of feed back of what was going on to see if was successful or failed.
Target Minecraft Versions: any
Requirements: none
Related Issues: none