-
Notifications
You must be signed in to change notification settings - Fork 484
Wiszb 120/121 add support #2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Wiszb 120/121 add support #2092
Conversation
@@ -0,0 +1,119 @@ | |||
-- Copyright 2022 SmartThings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date
Duplicate profile check: Passed - no duplicate profiles detected. |
local device_capabilities = get_device_capabilities(device) | ||
if device_capabilities ~= nil and device_capabilities.has_temperature then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
standard practice here is:
device:supports_capability_by_id([Capability.ID])
preferences: | ||
- preferenceId: tempOffset | ||
explicit: true | ||
- title: "Temperature Sensitivity (°)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is Celsius, could you indicate that? Some users may have their systems set to Fahrenheit
Test Results 66 files 424 suites 0s ⏱️ Results for commit d1b74ce. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against d1b74ce |
@@ -0,0 +1,280 @@ | |||
-- Copyright 2022 SmartThings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date
|
Invitation URL: |
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests