Skip to content

Wiszb 120/121 add support #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcintyminski
Copy link

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@@ -0,0 +1,119 @@
-- Copyright 2022 SmartThings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Comment on lines +70 to +71
local device_capabilities = get_device_capabilities(device)
if device_capabilities ~= nil and device_capabilities.has_temperature then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard practice here is:

device:supports_capability_by_id([Capability.ID])

preferences:
- preferenceId: tempOffset
explicit: true
- title: "Temperature Sensitivity (°)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is Celsius, could you indicate that? Some users may have their systems set to Fahrenheit

Copy link

Test Results

   66 files    424 suites   0s ⏱️
2 183 tests 2 183 ✅ 0 💤 0 ❌
3 716 runs  3 716 ✅ 0 💤 0 ❌

Results for commit d1b74ce.

Copy link

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/multi-sensor/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/smartsense-multi/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/frient/init.lua 96%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d1b74ce

@@ -0,0 +1,280 @@
-- Copyright 2022 SmartThings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

@greens
Copy link
Contributor

greens commented Apr 24, 2025

Checking drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua 4 warnings

    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:24:7: (W211) unused variable TemperatureMeasurement
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:26:7: (W211) unused variable IASCIEAddress
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:27:7: (W211) unused variable EnrollResponseCode
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:31:7: (W211) unused variable TEMPERATURE_MEASUREMENT_ENDPOINT

Checking drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor_pro.lua 2 warnings

    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor_pro.lua:26:7: (W211) unused variable IASCIEAddress
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor_pro.lua:27:7: (W211) unused variable EnrollResponseCode

Checking drivers/SmartThings/zigbee-contact/src/frient/init.lua 1 warning

    drivers/SmartThings/zigbee-contact/src/frient/init.lua:23:7: (W211) unused variable DEFAULT_TEMPERATURE_SENSITIVITY

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants