Modern gradle #596
Merged
Modern gradle #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue treating empty xml elements of the form <element/> as nil valued after upgrade to jackson past 2.12.x.
scribe
approved these changes
Aug 19, 2022
| import org.hamcrest.Description; | ||
| import org.hamcrest.TypeSafeMatcher; | ||
| import org.mockito.ArgumentMatcher; | ||
| import org.hamcrest.*; |
There was a problem hiding this comment.
Yep - I caught a few more of them that were added.
david-limbach
approved these changes
Aug 19, 2022
|
Travis keeps getting hung up running the test: I was able to run locally no problem. Travis is running a release of Oracle JDK from 2017 (1.8.0_151), and that might not be playing nice with the latest version of gradle (I'm running Temurin build 1.8.0_332-b09 locally). What I could do is make a new PR against current master to move to github actions for testing, and if that is smooth, then update this PR to use that. That will at least get us a more recent version of JDK 8 to work with. |
david-limbach
approved these changes
Aug 19, 2022
Use File.deleteOnExit() instead of FileUtils.deleteDirectory() from commons-io in testThatNamedPipeThrows() tests in FileObjectGetter and FileObjectPutter tests. Not sure why, but after the commons-io upgrade, the calls to FileUtils.deleteDirectory() started to hang.
david-limbach
approved these changes
Aug 19, 2022
scribe
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds supersedes #595. Starting with the work @scribe did, the new default behavior of jackson xml handling for empty xml elements was reverted to the previous default behavior and the tests passed. From there, more dependencies were updated, and the gradle build was moved from the groovy DSL to the kotlin DSL. Finally, gradle was upgraded from 7.5 to 7.5.1.
This work should result in the same build outputs and behavior as the previous build, with the exclusion of the configuration for artifact publishing, which was still configured to use bintray (will add publishing back in another PR to use GitHub packages).