Fix #23 - Added new rule G-3220: Always process saved exceptions from a FORALL statement.

Author: kibeha

docs/4-language-usage/3-dml-and-sql/2-bulk-operations/g-3220.md

@@ -0,0 +1,61 @@
+# G-3220: Always process saved exceptions from a FORALL statement.
+
+!!! warning "Major"
+    Reliability, Testability
+
+## Reason
+
+Using `save exceptions` in a `forall` statement without actually processing the saved exceptions is just wasted work.
+
+If your use of `forall` is meant to be atomic (all or nothing), don't use `save exceptions`. If you want to handle errors of individual rows and do use `save exceptions`, always include an exception handler block with a loop to process the saved exceptions.
+
+## Example (bad)
+
+``` sql
+declare
+   t_employee_ids   employee_api.t_employee_ids_type;
+   co_increase      constant employees.salary%type          := 0.1;
+   co_department_id constant departments.department_id%type := 10;
+   e_bulk_errors    exception;
+   pragma exception_init(e_bulk_errors,-24381);
+begin
+   t_employee_ids := employee_api.employee_ids_by_department(
+                        id_in => co_department_id
+                     );
+   <<process_employees>>
+   forall i in 1..t_employee_ids.count() save exceptions
+      update employees
+         set salary = salary + (salary * co_increase)
+       where employee_id = t_employee_ids(i);
+end;
+/
+```
+
+## Example (good)
+
+``` sql
+declare
+   t_employee_ids   employee_api.t_employee_ids_type;
+   co_increase      constant employees.salary%type          := 0.1;
+   co_department_id constant departments.department_id%type := 10;
+   e_bulk_errors    exception;
+   pragma exception_init(e_bulk_errors,-24381);
+begin
+   t_employee_ids := employee_api.employee_ids_by_department(
+                        id_in => co_department_id
+                     );
+   <<process_employees>>
+   forall i in 1..t_employee_ids.count() save exceptions
+      update employees
+         set salary = salary + (salary * co_increase)
+       where employee_id = t_employee_ids(i);
+exception
+   when e_bulk_errors then
+      <<handle_bulk_exceptions>>
+      for i in 1..sql%bulk_exceptions.count
+      loop
+         logger.log(sql%bulk_exceptions(indx).error_code);
+      end loop handle_bulk_exceptions;
+end;
+/
+```

docs/9-appendix/appendix.md

@@ -58,6 +58,7 @@ n/a | 3185 | Never use ROWNUM at the same query level as ORDER BY. | Major |  |
 n/a | 3190 | Avoid using NATURAL JOIN. | Major | ✘ |  |  |  | ✘ |  |  | 
 n/a | 3195 | Always use wildcards in a LIKE clause. | Minor |  |  | ✘ |  |  |  |  | 
 30 | 3210 | Always use BULK OPERATIONS (BULK COLLECT, FORALL) whenever you have to execute a DML statement for more than 4 times. | Major |  | ✘ |  |  |  |  |  | 
+n/a | 3220 | Always process saved exceptions from a FORALL statement. | Major |  |  |  |  | ✘ |  |  | ✘
 n/a | 3310 | Never commit within a cursor loop. | Critical |  | ✘ |  |  | ✘ |  |  | 
 n/a | 3320 | Try to move transactions within a non-cursor loop into procedures. | Major |  |  | ✘ |  |  | ✘ |  | ✘
 31 | 4110 | Always use %NOTFOUND instead of NOT %FOUND to check whether a cursor returned data. | Minor |  |  | ✘ |  |  |  |  |