Skip to content

feat: OnConnectionEvent callback usage in project and Utilities package [MTTB-1147] #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 7, 2025
Merged

feat: OnConnectionEvent callback usage in project and Utilities package [MTTB-1147] #907

merged 5 commits into from
Apr 7, 2025

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Apr 5, 2025 •
edited
Loading

Description

This PR upgrades the project to use the OnConnectionEvent callback from Netcode for GameObjects, in favour over the unrecommended OnClientConnected/OnClientDisconnected callbacks.

This PR also removes an unnecessary Despawn invocation on a NetworkObject that is already marked to despawn with owner.

Issue Number(s)

MTTB-1147

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

NoelStephensUnity
NoelStephensUnity previously approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@fernando-cortez fernando-cortez changed the title feat: OnConnectionEvent callback usage in project and Utilities package feat: OnConnectionEvent callback usage in project and Utilities package [MTTB-1147] Apr 7, 2025
@fernando-cortez fernando-cortez marked this pull request as ready for review April 7, 2025 20:16
@fernando-cortez fernando-cortez requested a review from a team as a code owner April 7, 2025 20:16
@fernando-cortez fernando-cortez mentioned this pull request Apr 7, 2025
Closed
7 tasks
kalmanbalint
kalmanbalint approved these changes Apr 7, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sentinel-u3d sentinel-u3d bot requested a review from kalmanbalint April 7, 2025 21:22
kalmanbalint
kalmanbalint approved these changes Apr 7, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fernando-cortez fernando-cortez merged commit 279e348 into develop Apr 7, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/on-connection-event-callback branch April 7, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalmanbalint kalmanbalint kalmanbalint approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @NoelStephensUnity @kalmanbalint