JDTB-31 Save log detail with Timestamp #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +24,8 @@ public function addEvent( | |||
| string $identifierValue = '', | |||
| int $severity = 1, | |||
| bool $createIssue = true, | |||
| \Exception $exception = null | |||
| \Exception $exception = null, | |||
| \DateTime $timestamp = null | |||
There was a problem hiding this comment.
These types are incorrect if null value is possible
| @@ -8,7 +8,7 @@ | |||
| <column xsi:type="int" name="severity" padding="11" unsigned="true" nullable="false" identity="false" comment="Severity"/> | |||
| <column xsi:type="varchar" name="identifier_label" nullable="true" length="20" comment="Identifier Label"/> | |||
| <column xsi:type="varchar" name="identifier_value" nullable="true" length="50" comment="Identifier Value"/> | |||
| <column xsi:type="timestamp" name="timestamp" nullable="false" default="CURRENT_TIMESTAMP" comment="Timestamp"/> | |||
| <column xsi:type="timestamp" name="timestamp" nullable="false" comment="Timestamp"/> | |||
There was a problem hiding this comment.
I am not sure here, it will not work if someone chooses to use default sync implementation. BTW I don't see any code for queues, so what is the point of this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://wearejh.atlassian.net/browse/JDTB-31
Description:
Save log detail with timestamp grabbed on event moment. Later, we will the sort the logger status table by timestamp.