Skip to content

Builders!!!!! #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 30, 2025
Merged

Builders!!!!! #44

merged 32 commits into from
May 30, 2025

Conversation

MelvinShwuaner
Copy link
Contributor

@MelvinShwuaner MelvinShwuaner commented May 3, 2025

ive been playing around with the custom sound system and noticed that 3d sounds are alot more quiet then normal sounds, and the only way to fix this is to add custom sounds to the in-game sound bank which is practically impossible.
so instead i turned 3d into a soundmode, you have basic (2d), stereo 3d (the original 3D) and mono 3d which doesn't use FMOD's 3D system but instead just changes volume over distance, this allows for loud sounds.

ive also implemented Builders!!!!! these are supposed to help modders create things, like tabs, assets, etc. ive only added a few but ive built the Architecture, i hope someone like tuxxego will build on it! i will also be building on it in the future

@MelvinShwuaner
Copy link
Contributor Author

@Keymasterer44
Copy link
Collaborator

Keymasterer44 commented May 5, 2025

I just took a look at this and was wondering about two things:

  1. Why are you completely deleting the ItemAssetCreator? I personally don't think adding a new utility is a good reason for deleting an existing one that still works, especially without former warning/deprecation.
  2. Did you test the achievement builder on Windows? I noticed that you hardcoded it to use unix Steamworks, and I'd be surprised if this works without error since unix Steamworks (iirc) always uses the Posix version of the DLL, which isn't bundled with Windows builds of WorldBox due to differences in how the internal APIs of each DLL work.
    Note that this isn't a complete review, I didn't fully look at all added code yet.

@MelvinShwuaner
Copy link
Contributor Author

I just took a look at this and was wondering about two things:

1. Why are you completely deleting the ItemAssetCreator? I personally don't think adding a new utility is a good reason for deleting an existing one that still works, especially without former warning/deprecation.

2. Did you test the achievement builder on Windows? I noticed that you hardcoded it to use unix Steamworks, and I'd be surprised if this works without error since unix Steamworks (iirc) always uses the Posix version of the DLL, which isn't bundled with Windows builds of WorldBox due to differences in how the internal APIs of each DLL work.
   Note that this isn't a complete review, I didn't fully look at all added code yet.

the item asset creator doesnt work as an issue had shown, and i thought it would be weird for 2 utilities to do the same thing.

@MelvinShwuaner
Copy link
Contributor Author

i tested asset file loading on actor trait assets,
image
here is an example
image
serializing your asset
image
and it worked.
image

@MelvinShwuaner
Copy link
Contributor Author

MelvinShwuaner commented May 12, 2025

Still have to fix localizatin

here ive added asset file loading, and ive also made linking assets much easier with master builders, you add builders to the master then buildall to build them and link their assets. this is also important for asset file loading,because of delegates! delegates cant be serialized, so i had to create a SerializableAsset class, this stores the variables along with the delegates info, and then once mod assemblies are loaded, the assets are loaded
@MelvinShwuaner
Copy link
Contributor Author

fixed it all

Copy link
Contributor

@inmny inmny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the methods in old ItemAssetCreator are just made for telling modder what parameters are useful for such kind of item.

@MelvinShwuaner
Copy link
Contributor Author

the methods in old ItemAssetCreator are just made for telling modder what parameters are useful for such kind of item.

Okay

@inmny inmny merged commit bf7a4d8 into WorldBoxOpenMods:master May 30, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants