Skip to content

feat: Refactored platform and prompt helpers #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Refactored platform and prompt helpers #183

wants to merge 8 commits into from

Conversation

chandrasekharan-zipstack
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack commented Apr 22, 2025 •
edited
Loading

What

  • Refactor of helpers that connect to platform and prompt service
  • Prompt service helper now raises an error on an exception instead of just logging and returning values
  • Added provision to pass a request_id for tracing
  • Bumped minor SDK version

Why

  • For better code reuse and maintainability

Notes on Testing

  • Tested locally

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

@chandrasekharan-zipstack
feat: Refactored platform and prompt helpers that connect to respecti…
1fa202a 
…ve services, added request ID support in headers
@chandrasekharan-zipstack chandrasekharan-zipstack marked this pull request as ready for review April 24, 2025 11:14
@chandrasekharan-zipstack chandrasekharan-zipstack mentioned this pull request Apr 29, 2025
Open
gaya3-zipstack
gaya3-zipstack approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@gaya3-zipstack gaya3-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaya3-zipstack gaya3-zipstack gaya3-zipstack approved these changes

@Deepak-Kesavan Deepak-Kesavan Awaiting requested review from Deepak-Kesavan

@harini-venkataraman harini-venkataraman Awaiting requested review from harini-venkataraman

At least 2 approving reviews are required to merge this pull request.

Assignees

@chandrasekharan-zipstack chandrasekharan-zipstack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandrasekharan-zipstack @gaya3-zipstack