Feat: Introduce bash-snippets.lib library
#247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move redundant function and variables into a shared bash script library file `bash-snippets.lib`. This allows the individual scripts to be more focused and maintainable.
- `bash-snippets.lib` is a dependency for the installer. - The installer now installs the shared library as part of its process. - Implemented command line option parsing in the installer.
Included guidelines for code style and formatting to ensure consistency across contributions.
- Parse short and long command line options - API response processed with `jq`
- Parse short and long command line options - Artist name and song name now are positional argument - Remove `-f` option; user can redirect output for desired output file - API response processed with `jq`
When the function Get_Info finishes execution, the variable will not be unsetted; Variable keys and values are declared as global variables.
Previously, the program output was fixed to a specific number of columns per line (80 columns) This changed to dynamically adjust the number of columns based on the current user shell width
… input - Fix number of columns increased by 2 on each iteration - Add blank line separator if multiple argument supplied - Implement stand alone function to set output width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move redundant function and variables into a shared bash script library file
bash-snippets.lib. This allows the individual scripts to be more focused and maintainable.Pull Request Label:
Pull Request Checklist:
bats tests?