-
Notifications
You must be signed in to change notification settings - Fork 2
Fixes & refactor #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for the contribution @daycry. Can you please provide more info why we need these changes? |
My changes imported from https://github.com/[daycry/phpunit-extension-vcr](https://github.com/daycry/phpunit-extension-vcr) |
Coding standards checks with composer cs command |
There are too many unrelated changes for a single PR. Please split them into several PRs instead, so we can discuss them separately. Don't forget to add description and examples on why the changes are needed. Here are few things which I don't think are needed:
|
Sorry, but I can't spend more time updating your package. You told me we can collaborate and I do. If you install want you can check these changes or you can delete it, but the changes made are very interesting. |
I asked you to push the changes that you needed here, so you can correct the fact that you had copied the code and removed the references to the original work. I can support adding these changes to this package, but that does not mean you can just throw a bunch of changes in one PR without any additional context. If what is present here does not work for you, you are free to fork it and modify it as you wish, but you have to respect the license. |
there are many changes in all the files because I have added your signature to the beginning of each file. If you are scared to see so many changes, I will divide them. |
No description provided.