Skip to content

Update the gateway inventory file vars #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

Update the gateway inventory file vars #3256

merged 4 commits into from
Apr 28, 2025

Conversation

michellemacrh
Copy link
Contributor

Platform gateway variables - Appendix Inventory file variables improvements

https://issues.redhat.com/browse/AAP-40602

@michellemacrh michellemacrh added Ready for technical review Content is ready for technical reviews 2.5 Content applies to AAP 2.5 Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels Apr 10, 2025
@simaishi
Copy link

There are also automationgateway_cache_cert, automationgateway_cache_key and other redis related variables that might be used for gateway.

@jamesmarshall24 can you confirm?

simaishi
simaishi reviewed Apr 16, 2025
View reviewed changes
downstream/modules/platform/ref-gateway-variables.adoc
| Optional
| `63072000`

|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RPM installer, nginx_tls_protocols is used for all components and the default is TLSv1.2

Copy link
Contributor Author

@michellemacrh michellemacrh Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good to know, nginx_tls_protocols is listed in the Controller vars section next to the Container equivalent controller_nginx_https_protocols.
Maybe we should list nginx_tls_protocols next to each equivalent section with that in mind 👍
Like here RPM = nginx_tls_protocols, Container = gateway_nginx_https_protocols

@michellemacrh michellemacrh force-pushed the AAP-40602 branch 2 times, most recently from 6579af9 to 6fe1bde Compare April 17, 2025 09:40
@michellemacrh
Copy link
Contributor Author

Thanks for taking the time to look thru the PR @simaishi!
I incorporated your feedback including adding in automationgateway_cache_cert, automationgateway_cache_key. CC @jamesmarshall24

dsavineau
dsavineau reviewed Apr 24, 2025
View reviewed changes
downstream/modules/platform/ref-gateway-variables.adoc Outdated
| `63072000`

|
| `gateway_redis_tls_cert`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the equivalent of automationgateway_cache_cert from RPM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks Dimitri :)

downstream/modules/platform/ref-gateway-variables.adoc Outdated
|

|
| `gateway_redis_tls_key`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same but for automationgateway_cache_key

@michellemacrh michellemacrh added Technical review complete Content has been reviewed for technical accuracy and completeness and removed Ready for technical review Content is ready for technical reviews labels Apr 28, 2025
EMcWhinn
EMcWhinn reviewed Apr 28, 2025
View reviewed changes
downstream/modules/platform/ref-gateway-variables.adoc Outdated

| `automationgateway_cache_tls_files_remote`
|
| Denote whether the cache client certificate are local to the installation program (`false`) or on the remote component server (`true`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "client" be plural or singular with "client certificate is local..."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, it should be plural I believe. Will correct!

EMcWhinn
EMcWhinn reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@EMcWhinn EMcWhinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor comment, rest LGTM.

EMcWhinn
EMcWhinn approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@EMcWhinn EMcWhinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMcWhinn EMcWhinn merged commit 4910e53 into ansible:main Apr 28, 2025
michellemacrh added a commit to michellemacrh/aap-docs that referenced this pull request Apr 28, 2025
@michellemacrh
Update the gateway inventory file vars (ansible#3256)
31abfb8 
* Update the gateway inventory file vars

Platform gateway variables - Appendix Inventory file variables improvements

https://issues.redhat.com/browse/AAP-40602

* updates based on SME feedback

* Updates based on SME feedback

* Updates based on peer review feedback
@michellemacrh michellemacrh mentioned this pull request Apr 28, 2025
Merged
EMcWhinn pushed a commit that referenced this pull request Apr 28, 2025
@michellemacrh
Update the gateway inventory file vars (#3256) (#3346)
543c240 
* Update the gateway inventory file vars

Platform gateway variables - Appendix Inventory file variables improvements

https://issues.redhat.com/browse/AAP-40602

* updates based on SME feedback

* Updates based on SME feedback

* Updates based on peer review feedback
@michellemacrh michellemacrh added Backported to 2.5 Changes have been applied to the AAP 2.5 branch and removed Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsavineau dsavineau dsavineau left review comments

@simaishi simaishi simaishi left review comments

@EMcWhinn EMcWhinn EMcWhinn approved these changes

Assignees
No one assigned
Labels
2.5 Content applies to AAP 2.5 Backported to 2.5 Changes have been applied to the AAP 2.5 branch Technical review complete Content has been reviewed for technical accuracy and completeness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellemacrh @simaishi @dsavineau @EMcWhinn