YARN-11809. Support application backoff mechanism for CapacityScheduler #7589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
TaoYang526
force-pushed
the
app-backoff-mechanism
branch
from
64260fd to
322fe34
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAppBackoff.java:170
- [nitpick] Consider increasing the sleep duration slightly above 100ms to ensure the backoff interval reliably expires, reducing potential flakiness in tests.
Thread.sleep(100L);
1fbb000 to
ff85582
Compare
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAppBackoff.java:171
- [nitpick] Using Thread.sleep for waiting on the backoff interval might lead to flaky tests under variable system load. Consider using a polling mechanism with a timeout to check for backoff expiration for increased reliability.
Thread.sleep(appBackoffIntervalMs + 10L);
ff85582 to
f3068f4
Compare
TaoYang526
force-pushed
the
app-backoff-mechanism
branch
from
f3068f4 to
79f2503
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
zeekling
suggested changes
Apr 10, 2025
| } else if (assignment.getSkippedType() | ||
| == CSAssignment.SkippedType.QUEUE_LIMIT) { | ||
| ActivitiesLogger.QUEUE.recordQueueActivity(activitiesManager, node, | ||
| parent.getQueuePath(), getQueuePath(), ActivityState.REJECTED, | ||
| () -> ActivityDiagnosticConstant.QUEUE_DO_NOT_HAVE_ENOUGH_HEADROOM | ||
| + " from " + application.getApplicationId()); | ||
| // Add missed scheduling opportunities for the application | ||
| application.addAppMissedSchedulingOpportunities(); | ||
| return assignment; | ||
| } else{ | ||
| // If we don't allocate anything, and it is not skipped by application, |
There was a problem hiding this comment.
Is this need application.addAppMissedSchedulingOpportunities(); ?
There was a problem hiding this comment.
Thanks @zeekling for the review.
This check was intended to quickly skip redundant checks for every node when reached the queue limit, which is already resolved in YARN-11798. So it's not necessary for the latest code, I'll remove this line later. Thanks for reminding this.
… limit is reached.
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Please refer to YARN-11809 for details.
How was this patch tested?
UT
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?