Skip to content

KAFKA-18752: Fix the warning of no-operation caused by slf4j in building kafka #19501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: trunk
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
65cbac4
KAFKA-18752: Fix the warning of no-operation caused by slf4j in build…
frankvicky Feb 12, 2025
829e18d
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 18, 2025
bd1481d
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 20, 2025
ebfcfcb
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 21, 2025
7bed642
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 24, 2025
f75e348
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 25, 2025
ee1ea07
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 25, 2025
3ea3da5
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 28, 2025
82921f5
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 29, 2025
f1fb688
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 30, 2025
1fe01bd
Merge branch 'trunk' into KAFKA-18752
frankvicky Apr 30, 2025
29d19e7
Merge branch 'trunk' into KAFKA-18752
frankvicky May 1, 2025
35bb7aa
Merge branch 'trunk' into KAFKA-18752
frankvicky May 2, 2025
66def92
Merge branch 'trunk' into KAFKA-18752
frankvicky May 3, 2025
bd32bad
Merge branch 'trunk' into KAFKA-18752
frankvicky May 5, 2025
4755f37
Merge branch 'trunk' into KAFKA-18752
frankvicky May 7, 2025
237840c
Merge branch 'trunk' into KAFKA-18752
frankvicky May 8, 2025
de48a3e
Merge branch 'trunk' into KAFKA-18752
frankvicky May 11, 2025
d5f094c
Merge branch 'trunk' into KAFKA-18752
frankvicky May 14, 2025
ff9a550
Merge branch 'trunk' into KAFKA-18752
frankvicky May 15, 2025
74a06f1
Merge branch 'trunk' into KAFKA-18752
frankvicky May 16, 2025
19db9d1
Merge branch 'trunk' into KAFKA-18752
frankvicky May 19, 2025
450023c
Merge branch 'trunk' into KAFKA-18752
frankvicky May 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 34 additions & 44 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -1078,80 +1078,65 @@ project(':core') {
duplicatesStrategy 'exclude'
}

tasks.withType(JavaExec) { task ->
if (task.name.startsWith('gen') && task.name.endsWith('Docs')) {
task.classpath = sourceSets.main.runtimeClasspath + configurations.releaseOnly
if(!generatedDocsDir.exists()) { generatedDocsDir.mkdirs() }
}
}

task genProtocolErrorDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.Errors'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_errors.html").newOutputStream()
}

task genProtocolTypesDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.types.Type'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_types.html").newOutputStream()
}

task genProtocolApiKeyDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.ApiKeys'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_api_keys.html").newOutputStream()
}

task genProtocolMessageDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.Protocol'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_messages.html").newOutputStream()
}

task genAdminClientConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.admin.AdminClientConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "admin_client_config.html").newOutputStream()
}

task genProducerConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.producer.ProducerConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "producer_config.html").newOutputStream()
}

task genConsumerConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.consumer.ConsumerConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "consumer_config.html").newOutputStream()
}

task genKafkaConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'kafka.server.KafkaConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "kafka_config.html").newOutputStream()
}

task genTopicConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.storage.internals.log.LogConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "topic_config.html").newOutputStream()
}

task genConsumerMetricsDocs(type: JavaExec) {
classpath = sourceSets.test.runtimeClasspath
mainClass = 'org.apache.kafka.clients.consumer.internals.ConsumerMetrics'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "consumer_metrics.html").newOutputStream()
}

task genProducerMetricsDocs(type: JavaExec) {
classpath = sourceSets.test.runtimeClasspath
mainClass = 'org.apache.kafka.clients.producer.internals.ProducerMetrics'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "producer_metrics.html").newOutputStream()
}

Expand Down Expand Up @@ -2605,9 +2590,12 @@ project(':streams') {

configurations {
generator
releaseOnly
}

dependencies {
releaseOnly log4jReleaseLibs

api project(path: ':clients', configuration: 'shadow')
// `org.rocksdb.Options` is part of Kafka Streams public api via `RocksDBConfigSetter`
api libs.rocksDBJni
Expand Down Expand Up @@ -2711,7 +2699,7 @@ project(':streams') {
}

task genStreamsConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
classpath = sourceSets.main.runtimeClasspath + configurations.releaseOnly
mainClass = 'org.apache.kafka.streams.StreamsConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "streams_config.html").newOutputStream()
Expand Down Expand Up @@ -3462,13 +3450,15 @@ project(':connect:json') {
project(':connect:runtime') {
configurations {
swagger
releaseOnly
}

base {
archivesName = "connect-runtime"
}

dependencies {
releaseOnly log4jReleaseLibs
// connect-runtime is used in tests, use `api` for modules below for backwards compatibility even though
// applications should generally not depend on `connect-runtime`
api project(':connect:api')
Expand Down Expand Up @@ -3555,45 +3545,40 @@ project(':connect:runtime') {
dependsOn copyDependantLibs
}

tasks.withType(JavaExec) { task ->
if (task.name.startsWith('gen') && task.name.endsWith('Docs')) {
task.classpath = sourceSets.main.runtimeClasspath + configurations.releaseOnly
if(!generatedDocsDir.exists()) { generatedDocsDir.mkdirs() }
}
}

task genConnectConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.runtime.distributed.DistributedConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "connect_config.html").newOutputStream()
}

task genSinkConnectorConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.runtime.SinkConnectorConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "sink_connector_config.html").newOutputStream()
}

task genSourceConnectorConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.runtime.SourceConnectorConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "source_connector_config.html").newOutputStream()
}

task genConnectTransformationDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.tools.TransformationDoc'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "connect_transforms.html").newOutputStream()
}

task genConnectPredicateDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.tools.PredicateDoc'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "connect_predicates.html").newOutputStream()
}

task genConnectMetricsDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.runtime.ConnectMetrics'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "connect_metrics.html").newOutputStream()
}

Expand All @@ -3605,7 +3590,7 @@ project(':connect:runtime') {
}

task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: setVersionInOpenAPISpec) {
classpath = sourceSets.main.runtimeClasspath
classpath = sourceSets.main.runtimeClasspath + configurations.releaseOnly

buildClasspath = classpath + configurations.swagger
outputFileName = 'connect_rest'
Expand Down Expand Up @@ -3706,7 +3691,13 @@ project(':connect:mirror') {
archivesName = "connect-mirror"
}

configurations {
releaseOnly
}

dependencies {
releaseOnly log4jReleaseLibs

implementation project(':connect:api')
implementation project(':connect:runtime')
implementation project(':connect:mirror-client')
Expand Down Expand Up @@ -3764,31 +3755,30 @@ project(':connect:mirror') {
duplicatesStrategy 'exclude'
}

tasks.withType(JavaExec) { task ->
if (task.name.startsWith('gen') && task.name.endsWith('Docs')) {
task.classpath = sourceSets.main.runtimeClasspath + configurations.releaseOnly
if(!generatedDocsDir.exists()) { generatedDocsDir.mkdirs() }
}
}

task genMirrorConnectorConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.mirror.MirrorConnectorConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "mirror_connector_config.html").newOutputStream()
}

task genMirrorSourceConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.mirror.MirrorSourceConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "mirror_source_config.html").newOutputStream()
}

task genMirrorCheckpointConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.mirror.MirrorCheckpointConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "mirror_checkpoint_config.html").newOutputStream()
}

task genMirrorHeartbeatConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.connect.mirror.MirrorHeartbeatConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "mirror_heartbeat_config.html").newOutputStream()
}

Expand Down