Skip to content

KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException #19507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException #19507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8384a08
KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException
mjsax Apr 17, 2025
cd9d888
review
mjsax Apr 25, 2025
1e970f1
formatting
mjsax Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,14 @@ private void handleTasksWithStateUpdater(final Map<TaskId, Set<TopicPartition>>

private void handleTasksPendingInitialization() {
// All tasks pending initialization are not part of the usual bookkeeping

final Set<Task> tasksToCloseDirty = new HashSet<>();

for (final Task task : tasks.drainPendingTasksToInit()) {
closeTaskClean(task, Collections.emptySet(), Collections.emptyMap());
closeTaskClean(task, tasksToCloseDirty, new HashMap<>());
}
for (final Task task : tasksToCloseDirty) {
closeTaskDirty(task, false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if we need to pass true or false here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should pass false. With the state updater newly created or revived tasks are not added to the task registry immediately but only when they are ready for running.

}
}

Expand Down Expand Up @@ -1312,7 +1318,6 @@ private void closeRunningTasksDirty() {
private void removeLostActiveTasksFromStateUpdaterAndPendingTasksToInit() {
if (stateUpdater != null) {
final Map<TaskId, CompletableFuture<StateUpdater.RemovedTaskResult>> futures = new LinkedHashMap<>();
final Map<TaskId, RuntimeException> failedTasksDuringCleanClose = new HashMap<>();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side cleanup -- unused.

final Set<Task> tasksToCloseClean = new HashSet<>(tasks.drainPendingActiveTasksToInit());
final Set<Task> tasksToCloseDirty = new HashSet<>();
for (final Task restoringTask : stateUpdater.tasks()) {
Expand All @@ -1323,7 +1328,7 @@ private void removeLostActiveTasksFromStateUpdaterAndPendingTasksToInit() {

addToTasksToClose(futures, tasksToCloseClean, tasksToCloseDirty);
for (final Task task : tasksToCloseClean) {
closeTaskClean(task, tasksToCloseDirty, failedTasksDuringCleanClose);
closeTaskClean(task, tasksToCloseDirty, new HashMap<>());
}
for (final Task task : tasksToCloseDirty) {
closeTaskDirty(task, false);
Expand Down