Skip to content

fix: array shape in ProviderInterface #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 4.1
Choose a base branch
from

Conversation

nesl247
Copy link
Contributor

@nesl247 nesl247 commented May 15, 2025

Q A
Branch? 4.1
Tickets N/A
License MIT
Doc PR N/A

With this syntax request and resource_class can be detected. Otherwise it just becomes an unsealed associative array.

See phpstan/phpdoc-parser#250 for the syntax. I reported phpstan/phpstan#13019 because the extra keys aren't working as per the PR that added support, but the known keys do.

@nesl247 nesl247 marked this pull request as draft May 15, 2025 14:17
@nesl247 nesl247 changed the title fix: #7119 array shape in ProviderInterface fix: array shape in ProviderInterface May 15, 2025
With this syntax `request` and `resource_class` can be detected. Otherwise it just becomes an unsealed associative array.
@nesl247 nesl247 marked this pull request as ready for review May 15, 2025 14:18
@soyuka
Copy link
Member

soyuka commented May 16, 2025

needs #7154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants