-
Notifications
You must be signed in to change notification settings - Fork 12
ci: Automate the release process #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janbuchar
commented
Oct 22, 2024
- closes Automatically generate changelog from the commit messages #241
6903822
to
60aded7
Compare
907f68b
to
8da9ff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but please update also:
.pre-commit-config.yaml
- rm legacy checks,Makefile
- rm legacy commands,- and
CONTRIBUTING.md
- basically just copy it from Crawlee and make necessary adjustments.- Which will also close Mention poetry in CONTRIBURING.md #288.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're removing run_release.yaml
in the client, but leaving it in here. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All our pipeline files so far follow a verb-based naming style (build_and_deploy_docs.yaml
, check_pr_title.yaml
, run_code_checks.yaml
, update_new_issue.yaml
). The release pipelines, however, are named release
and pre_release
. While I'm not insisting we have to use verb-style naming—I'm not sure what the best convention is—but please keep it consistent.
but |
|
It isn't! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks