Skip to content

ci: Automate the release process #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 30, 2024
Merged

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 22, 2024
@janbuchar janbuchar requested a review from vdusek October 22, 2024 14:19
@github-actions github-actions bot added this to the 101st sprint - Tooling team milestone Oct 22, 2024
@janbuchar janbuchar had a problem deploying to fork-pr-integration-tests October 22, 2024 14:28 — with GitHub Actions Error
@janbuchar janbuchar temporarily deployed to fork-pr-integration-tests October 22, 2024 14:40 — with GitHub Actions Inactive
@janbuchar janbuchar force-pushed the automated-release-process branch from 6903822 to 60aded7 Compare October 29, 2024 11:05
@janbuchar janbuchar force-pushed the automated-release-process branch from 907f68b to 8da9ff6 Compare October 29, 2024 12:54
@janbuchar janbuchar marked this pull request as ready for review October 29, 2024 12:54
@janbuchar janbuchar requested a review from B4nan October 29, 2024 12:55
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but please update also:

  • .pre-commit-config.yaml - rm legacy checks,
  • Makefile - rm legacy commands,
  • and CONTRIBUTING.md - basically just copy it from Crawlee and make necessary adjustments.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're removing run_release.yaml in the client, but leaving it in here. Is that correct?

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our pipeline files so far follow a verb-based naming style (build_and_deploy_docs.yaml, check_pr_title.yaml, run_code_checks.yaml, update_new_issue.yaml). The release pipelines, however, are named release and pre_release. While I'm not insisting we have to use verb-style naming—I'm not sure what the best convention is—but please keep it consistent.

@B4nan
Copy link
Member

B4nan commented Oct 29, 2024

but release is also verb, right? :]

@janbuchar
Copy link
Contributor Author

All our pipeline files so far follow a verb-based naming style (build_and_deploy_docs.yaml, check_pr_title.yaml, run_code_checks.yaml, update_new_issue.yaml). The release pipelines, however, are named release and pre_release. While I'm not insisting we have to use verb-style naming—I'm not sure what the best convention is—but please keep it consistent.

but release is also verb, right? :]

apify/apify-client-python#278 (comment)

@janbuchar
Copy link
Contributor Author

We're removing run_release.yaml in the client, but leaving it in here. Is that correct?

It isn't! Thank you!

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks

@janbuchar janbuchar merged commit 65f2500 into master Oct 30, 2024
23 checks passed
@janbuchar janbuchar deleted the automated-release-process branch October 30, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate changelog from the commit messages
3 participants