Add Android imports to tests #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason I haven't submitted that patch is that I only need it when cross-compiling, ie I don't need it when natively compiling on Android. There are some weird import issues I've been seeing since last summer, possibly related to the Foundation rewrite. Since this is one of them, I've been holding off on submitting it, as I want to investigate the root cause at some point. However, if you want to just fix this for cross-compilation now, nothing against that: go for it. |
Yes, I'd like to get this building now, since it is causing some dependent packages at https://swift-everywhere.org that are failing. |
marcprux
added a commit
to swift-everywhere/swift-package-builds
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for constants like
O_RDWR, completing the work in #187 and eliminating the need for @finagolfin's swift-system-tests.patch