Skip to content

Fix error handler controllers failing test-compilation #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

SentryMan
Copy link
Collaborator

What was happening was that a controller with only error handlers would fail to have the TestClient Generate properly, this ensures that nothing without valid HTTP methods will get a test client generated

@SentryMan SentryMan added the bug Something isn't working label Apr 19, 2025
@SentryMan SentryMan added this to the 3.3 milestone Apr 19, 2025
@SentryMan SentryMan requested a review from rbygrave April 19, 2025 01:06
@SentryMan SentryMan self-assigned this Apr 19, 2025
@SentryMan SentryMan enabled auto-merge April 19, 2025 01:06
@rbygrave rbygrave disabled auto-merge April 23, 2025 10:43
@rbygrave rbygrave merged commit 551a5cb into avaje:master Apr 23, 2025
5 checks passed
@SentryMan SentryMan deleted the ErrorControllers branch April 23, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants