Skip to content

Reduce Boto3 retrial attempts to 1 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.6', '3.7', '3.8', '3.9']

python-version: ['3.7', '3.8', '3.9']
include:
- os: macos-latest
python-version: '3.6'
- os: windows-latest
python-version: '3.6'
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
Expand Down
5 changes: 4 additions & 1 deletion codeguru_profiler_agent/codeguru_client_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ def _create_codeguru_client(self):
region = self._get_region_or_default()

# the default retry mode is 'legacy', not 'standard'
# retry at most once to avoid retry storms
# see https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html
standard_config = Config(
retries={
retries = {
'max_attempts': 1,
'mode': 'standard'
}
)
Expand Down
2 changes: 1 addition & 1 deletion release_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

# The following values are used in the documentation, so any change of them requires updates to the documentation.
LAYER_NAME = 'AWSCodeGuruProfilerPythonAgentLambdaLayer'
SUPPORTED_VERSIONS = ['3.6', '3.7', '3.8', '3.9']
SUPPORTED_VERSIONS = ['3.7', '3.8', '3.9']
EXEC_SCRIPT_FILE_NAME = 'codeguru_profiler_lambda_exec'

# We should release in all the regions that lambda layer is supported, not just the ones CodeGuru Profiler Service supports.
Expand Down
4 changes: 3 additions & 1 deletion test/unit/metrics/test_with_timer.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ def foo_wall(self):
@with_timer(metric_name="test-foo-cpu", measurement="cpu-time")
def foo_cpu(self):
# Run something to make sure the cpu clock does tick (https://bugs.python.org/issue37859)
len(str(2 ** 500_000))
sum_x = 0
for i in range(10000000):
sum_x += i
return


Expand Down