support for json to/from types.AttributeValue #3071
Conversation
raduendv
force-pushed
the
feat-json-attribute-value
branch
from
26d9d88 to
85cdf5a
Compare
raduendv
force-pushed
the
feat-json-attribute-value
branch
from
85cdf5a to
c87966c
Compare
| if value != nil { | ||
| jtv, ok := value.(bool) | ||
| if !ok { | ||
| return fmt.Errorf("expected NullAttributeValue to be of type *bool, got %T instead", value) |
There was a problem hiding this comment.
[nit] shouldn't this be just bool?
|
|
||
| shape, ok := value.([]interface{}) | ||
| if !ok { | ||
| return fmt.Errorf("unexpected JSON type %v", value) |
There was a problem hiding this comment.
[nit] can we also include what type we expected, like fmt.Errorf("expected a JSON list, got type %T val %v")
|
|
||
| for key, value := range shape { | ||
| var parsedVal types.AttributeValue | ||
| mapVar := parsedVal |
There was a problem hiding this comment.
[nit] I don't think this intermediate variable is necessary
| name: "&types.AttributeValueMemberM", | ||
| input: &types.AttributeValueMemberM{ | ||
| Value: map[string]types.AttributeValue{ | ||
| // we only use 1 key here because go does not guarantee key order and test will fail randomly |
There was a problem hiding this comment.
[nit] We could also special case this and check against each key instead of just doing just string comparison, but this is fine as well
| expected: `{"N":"123"}`, | ||
| }, | ||
| { | ||
| name: "&types.AttributeValueMemberN 2", |
There was a problem hiding this comment.
There are some special cases on DynamoDB for small or huge numbers that I'd also like to see tested, like numbers larger than math.MaxInt64. I'm sure current implementation would handle it, but it would give me peace of mind to have it explicitly tested
Implements the following functions for both
feature/dynamodb/attributevalueandfeature/dynamodbstreams/attributevalueto solve #2920 :func UnmarshalListJSON(data []byte) ([]types.AttributeValue, error) {func UnmarshalMapJSON(data []byte) (map[string]types.AttributeValue, error) {func UnmarshalJSON(data []byte) (types.AttributeValue, error) {func MarshalListJSON(in []types.AttributeValue) ([]byte, error) {func MarshalMapJSON(in map[string]types.AttributeValue) ([]byte, error) {func MarshalJSON(in types.AttributeValue) ([]byte, error) {Each package makes use of the correct
typespackage (service/dynamodb/typesforfeature/dynamodb/attributevalueandservice/dynamodbstreams/typesforfeature/dynamodbstreams/attributevalue)