Better arn parsing #6163
Open
Better arn parsing #6163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
davidh44
approved these changes
Jun 6, 2025
zoewangg
requested changes
Jun 6, 2025
| * @param arn A string containing an ARN to parse. | ||
| * @return An {@link Optional} containing the parsed {@link Arn} if valid, or empty if invalid. | ||
| */ | ||
| public static Optional<Arn> tryFromString(String arn) { |
There was a problem hiding this comment.
It contains a lot of duplicate code. Can we extract common code?
One idea is to create a helper method that takes a boolean for throwing behavior private static Optional<Arn> parseArn(String arn, boolean throwOnError) {...}
Comment on lines
+388
to
+392
| public void tryFromString_InvalidArns_ShouldThrowExceptions(String testName, String arnString) { | ||
| assertThrows(IllegalArgumentException.class, () -> { | ||
| Arn.tryFromString(arnString); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Hmm, I thought it would no longer throw exception, did I miss anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Addresses #6108 .
Currently the SDK uses exceptions as control flow for arn parsing. This is an anti pattern in Java and can cause performance overhead.
Modifications
This PR adds another arn parsing method
tryFromString(arn)that would return an Optional of Arn when the arn is valid, and an empty when it is invalid - this avoids the hot path of throwing exceptions as control flow.Testing
Unit tests: