-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix: fix the issue due to PR changes, 5122 #5124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aining script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container
Thank you for fixing this issue. We ran into this today on our production pipelines. It took us a minute to figure out why our pipeline processingStep wasn't getting parameters anymore: "ContainerArguments": [ . |
Similar situation here - thank you for reverting this code. It would have broken our production pipelines if we were to redeploy or make any changes. |
This does not fix the issue. The offending code is:
This produces the broken arguments:
The Dockerimages look like this:
|
* change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container * feature: Enabled update_endpoint through model_builder * fix: fix unit test, black-check, pylint errors * fix: fix black-check, pylint errors * fix:Added handler for pipeline variable while creating process job * fix: Added handler for pipeline variable while creating process job * Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/P223568185/overview * Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>
Issue #, if available:
https://t.corp.amazon.com/P223568185/overview
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.