Skip to content

Fix: fix the issue due to PR changes, 5122 #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 15, 2025

Conversation

rsareddy0329
Copy link
Contributor

@rsareddy0329 rsareddy0329 commented Apr 14, 2025

Issue #, if available:
https://t.corp.amazon.com/P223568185/overview

Description of changes:

Testing done:

  • Tested the relevant unit tests.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Roja Reddy Sareddy and others added 28 commits January 29, 2025 00:07
…aining script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container
@rsareddy0329 rsareddy0329 requested a review from a team as a code owner April 14, 2025 04:06
@rsareddy0329 rsareddy0329 requested a review from benieric April 14, 2025 04:06
@rsareddy0329 rsareddy0329 changed the title Revert the PR changes: #5122 Revert the PR changes:5122 Apr 14, 2025
@rsareddy0329 rsareddy0329 changed the title Revert the PR changes:5122 Fix: fix the issue due to PR changes, 5122 Apr 14, 2025
@koups496
Copy link

koups496 commented Apr 14, 2025

Thank you for fixing this issue. We ran into this today on our production pipelines. It took us a minute to figure out why our pipeline processingStep wasn't getting parameters anymore:

"ContainerArguments": [
"--horizon",
"{\"Get\": \"Parameters.HorizonLength\"}"
],

.

@joshpulse
Copy link

Similar situation here - thank you for reverting this code. It would have broken our production pipelines if we were to redeploy or make any changes.

@rsareddy0329 rsareddy0329 merged commit 6d52a81 into aws:master Apr 15, 2025
13 of 14 checks passed
@DRKolev-code
Copy link

This does not fix the issue. The offending code is:

                if isinstance(arg, PipelineVariable):
                    processed_value = json.dumps(arg.expr)
                    processed_arguments.append(processed_value)
                    print(processed_value)
                    print("YES")

This produces the broken arguments:

NO: --test_dict
YES: {"Get": "Parameters.test_dict"}
NO: --test_list
YES: {"Get": "Parameters.test_list"}
NO: --test_string
YES: {"Get": "Parameters.test_string"}
NO: --test_bool
YES: {"Std:Join": {"On": "", "Values": [{"Get": "Parameters.test_bool"}]}}
NO: --test_float
YES: {"Std:Join": {"On": "", "Values": [{"Get": "Parameters.test_float"}]}}
NO: --test_int
YES: {"Std:Join": {"On": "", "Values": [{"Get": "Parameters.test_int"}]}}
NO: --test_param
YES: {"Get": "Parameters.test_param"}

The Dockerimages look like this:

                                 - --test_dict
                                 - '{"Get": "Parameters.test_dict"}'
                                 - --test_list
                                 - '{"Get": "Parameters.test_list"}'
                                 - --test_string
                                 - '{"Get": "Parameters.test_string"}'
                                 - --test_bool
                                 - '{"Std:Join": {"On": "", "Values": [{"Get":
                             "Parameters.test_bool"}]}}'
                                 - --test_float
                                 - '{"Std:Join": {"On": "", "Values": [{"Get":
                             "Parameters.test_float"}]}}'
                                 - --test_int
                                 - '{"Std:Join": {"On": "", "Values": [{"Get":
                             "Parameters.test_int"}]}}'
                                 - --test_param
                                 - '{"Get": "Parameters.test_param"}'

mollyheamazon pushed a commit that referenced this pull request Apr 21, 2025
* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container

* feature: Enabled update_endpoint through model_builder

* fix: fix unit test, black-check, pylint errors

* fix: fix black-check, pylint errors

* fix:Added handler for pipeline variable while creating process job

* fix: Added handler for pipeline variable while creating process job

* Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/P223568185/overview

* Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication

---------

Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants