Skip to content

Java V2 Add the AWS Batch Scout #6714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Aug 22, 2024
Merged

Java V2 Add the AWS Batch Scout #6714

merged 30 commits into from
Aug 22, 2024

Conversation

scmacdon
Copy link
Contributor

@scmacdon scmacdon commented Aug 6, 2024

This pull request adds the Java V2 AWS Batch Scout.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Basics A basic code example showing the core actions for a particular service. labels Aug 6, 2024
@scmacdon scmacdon self-assigned this Aug 6, 2024
@scmacdon scmacdon requested a review from ford-at-aws August 18, 2024 17:26
ford-at-aws
ford-at-aws suggested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and comments!

ford-at-aws
ford-at-aws approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few concerns with the CDK/CFN templates but I agree they are mostly out of scope.

@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Aug 22, 2024
@meyertst-aws meyertst-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 22, 2024
@meyertst-aws meyertst-aws merged commit 4265f25 into awsdocs:main Aug 22, 2024
18 of 19 checks passed
shepazon pushed a commit to shepazon/aws-doc-sdk-examples that referenced this pull request Aug 27, 2024
@scmacdon @shepazon
Java V2 Add the AWS Batch Scout (awsdocs#6714)
43b8e02 
* added eng spec for AWS Batch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ford-at-aws ford-at-aws ford-at-aws approved these changes

Assignees

@scmacdon scmacdon

Labels
Basics A basic code example showing the core actions for a particular service. Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scmacdon @ford-at-aws @meyertst-aws