Skip to content

Swift: Added video generation example code for Nova Reel, Amazon Bedrock #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

monadierickx
Copy link
Contributor

This pull request includes a basic video generation code example, modeled after the python example.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Swift This issue relates to the AWS SDK for Swift label May 25, 2025
@brmur brmur requested a review from shepazon May 28, 2025 12:39
Copy link
Contributor

@shepazon shepazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending correction of line 78 issue.

prompt: "A pomegranate juice in a railway station",
outputS3Uri: bucket
)
print(f"Job started with invocation ARN: {invocation_arn}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax doesn't work. Isn't this a Python syntax? Shouldn't this instead be print("Job started with invocation ARN: \(invocation_arn)")?

If it works for you, I'd be interested to know how, since I get syntax errors on these lines:

 76 |         outputS3Uri: bucket
 77 |     )
 78 |     print(f"Job started with invocation ARN: {invocation_arn}")
    |            `- error: expected ',' separator
 79 |
 80 |     // Poll for job completion

/Users/ericsh/tmp/reel/Sources/main.swift:78:11: error: cannot find 'f' in scope

 76 |         outputS3Uri: bucket
 77 |     )
 78 |     print(f"Job started with invocation ARN: {invocation_arn}")
    |           `- error: cannot find 'f' in scope
 79 |
 80 |     // Poll for job completion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this issue is fixed, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Swift This issue relates to the AWS SDK for Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants